Use local tsdown binary for server build command#569
Use local tsdown binary for server build command#569Mizaro wants to merge 2 commits intopingdotgg:mainfrom
Conversation
- Resolve `tsdown` from `apps/server/node_modules/.bin` before running build - Support Windows binary variants (`.exe`, `.cmd`) and fail with a clear error if missing
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Would prefer to fix this everywhere and not just one spot. #495 |
Thanks for taking the time to look. I would really like to contribute more |
Summary
tsdownfromapps/server/node_modules/.bininstead of invokingbun tsdowntsdown.exe,tsdown.cmd) before falling back totsdowntsdownbinary is missingCloses #568.
Note
Run
bun tsdownvia a shell on Windows inapps/server/scripts/cli.tsto use the local tsdown binaryAdd
shell: process.platform === "win32"to theChildProcess.makeinvocation in cli.ts for thebuildCmdcommand.📍Where to Start
Start with the
buildCmdimplementation and itsChildProcess.makecall in cli.ts.Macroscope summarized 6a720ed.