Skip to content

Use local tsdown binary for server build command#569

Closed
Mizaro wants to merge 2 commits intopingdotgg:mainfrom
Mizaro:t3code/interpret-a-message
Closed

Use local tsdown binary for server build command#569
Mizaro wants to merge 2 commits intopingdotgg:mainfrom
Mizaro:t3code/interpret-a-message

Conversation

@Mizaro
Copy link
Copy Markdown

@Mizaro Mizaro commented Mar 8, 2026

Summary

  • resolve tsdown from apps/server/node_modules/.bin instead of invoking bun tsdown
  • support Windows binary variants (tsdown.exe, tsdown.cmd) before falling back to tsdown
  • fail with a clear error when the local tsdown binary is missing

Closes #568.

Note

Run bun tsdown via a shell on Windows in apps/server/scripts/cli.ts to use the local tsdown binary

Add shell: process.platform === "win32" to the ChildProcess.make invocation in cli.ts for the buildCmd command.

📍Where to Start

Start with the buildCmd implementation and its ChildProcess.make call in cli.ts.

Macroscope summarized 6a720ed.

- Resolve `tsdown` from `apps/server/node_modules/.bin` before running build
- Support Windows binary variants (`.exe`, `.cmd`) and fail with a clear error if missing
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 8, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: d5f48a81-8e1e-4de8-8950-4f157e4caa26

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@t3dotgg
Copy link
Copy Markdown
Member

t3dotgg commented Mar 9, 2026

Would prefer to fix this everywhere and not just one spot. #495

@t3dotgg t3dotgg closed this Mar 9, 2026
@Mizaro Mizaro deleted the t3code/interpret-a-message branch March 9, 2026 05:58
@Mizaro
Copy link
Copy Markdown
Author

Mizaro commented Mar 9, 2026

Would prefer to fix this everywhere and not just one spot. #495

Thanks for taking the time to look. I would really like to contribute more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix: Development on Windows, bun cannot find tsdown

2 participants