fix(windows): hover-effect-fix-in-the-branch-ui#1559
fix(windows): hover-effect-fix-in-the-branch-ui#1559juliusmarminge merged 9 commits intopingdotgg:mainfrom
Conversation
(cherry picked from commit 7236690)
- Apply shared hover/selected/highlight class to all branch combobox items - Keep branch action rows and branch rows visually consistent in the selector (cherry picked from commit 7fb763f)
(cherry picked from commit 364a61f)
(cherry picked from commit 377f62c)
(cherry picked from commit a449e61)
(cherry picked from commit ef1bdc7)
(cherry picked from commit 8b03884)
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Co-authored-by: Ewan <ewanjordaan07@gmail.com>
Co-authored-by: Ewan <ewanjordaan07@gmail.com>

What Changed
mainWhy
The original work in #1038 fixed most of the Windows hover-state problem, but the final branch-selector override still made
data-selectedanddata-highlightedcollapse into the same full-accent treatment.This PR preserves the original author's work directly and adds the minimal follow-up needed so:
Notes
Checklist
Note
Low Risk
Low risk CSS-only changes that adjust hover/selected styling for list items; main risk is minor visual regressions across components using
ComboboxItem/AutocompleteItem.Overview
Fixes branch selector (and other list pickers) so hover/highlight and selected states render distinctly, improving Windows hover behavior.
Moves hover/selected styling into the shared
ComboboxItemandAutocompleteItembase classes (addshover:bg-accent,data-selected:bg-accent/50, and explicit combined highlighted+selected rules) and removes theBranchToolbarBranchSelectorper-itemclassNameoverride that previously forced full-accent styling for the active branch.Written by Cursor Bugbot for commit acfedc1. This will update automatically on new commits. Configure here.
Note
Fix hover and selected state styles in branch selector, combobox, and autocomplete items
hover:bg-accent,data-selected:bg-accent/50, anddata-selected:text-foregroundtoComboboxItemandAutocompleteItemso these states are handled by the components themselves.BranchToolbarBranchSelectorthat previously appliedbg-accent text-foregroundwhen an item matched the active branch, deferring to the component's own state classes.Macroscope summarized acfedc1.