Inline sqlite error classification#1515
Merged
juliusmarminge merged 1 commit intomainfrom Mar 29, 2026
Merged
Conversation
- Remove the local wrapper helper - Call `classifySqliteError` directly at each failure site
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
sfncore
pushed a commit
to sfncore/t3code
that referenced
this pull request
Mar 29, 2026
Upstream changes (v0.0.15): - Refactor projection pipeline side effects (pingdotgg#1512) - Inline sqlite error classification (pingdotgg#1515) - DrainableWorker drain off outstanding count (pingdotgg#1514) - Thread archiving with archivedAt (pingdotgg#1505-related migrations) - Auto-generate first-turn thread titles (pingdotgg#1375) - Keyboard shortcuts for sidebar threads (pingdotgg#1456) - Various UI fixes (sidebar, settings, markdown links) Conflict resolution: - ProjectionPipeline.ts: took upstream (our REINDEX workaround no longer needed with doltlite canDefer=0 fix) - Migrations.ts: renumbered our 016-018 to 019-021, keeping upstream's 016-018 (CanonicalizeModelSelections, ArchivedAt) - ProjectionThreads.ts, orchestration.ts: took upstream (archiving) - Sidebar files: took upstream (new features) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
AustinKelsay
pushed a commit
to AustinKelsay/t3code-custom
that referenced
this pull request
Mar 29, 2026
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
classifySqliteErrordirectly at each failure siteWhat Changed
Why
UI Changes
Checklist
Note
Low Risk
Low risk refactor limited to sqlite error construction; behavior should be unchanged aside from slightly different call sites for error classification.
Overview
Removes the local
classifyErrorhelper inNodeSqliteClientand inlinesclassifySqliteErrorat each statementprepare/executefailure site.This is a small refactor that keeps the same error messages/operations while making the error-classification calls explicit where
SqlErroris created.Written by Cursor Bugbot for commit 774bd62. This will update automatically on new commits. Configure here.
Note
Inline
classifySqliteErrorcalls inNodeSqliteClientby removing local helperRemoves the local
classifyErrorwrapper in NodeSqliteClient.ts and replaces its three call sites with direct calls toclassifySqliteError(cause, { message, operation }). No logic or behavior changes.Macroscope summarized 774bd62.