Skip to content

Inline sqlite error classification#1515

Merged
juliusmarminge merged 1 commit intomainfrom
feature/inline-sqlite-error-classification
Mar 29, 2026
Merged

Inline sqlite error classification#1515
juliusmarminge merged 1 commit intomainfrom
feature/inline-sqlite-error-classification

Conversation

@juliusmarminge
Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge commented Mar 29, 2026

  • Remove the local wrapper helper
  • Call classifySqliteError directly at each failure site

What Changed

Why

UI Changes

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Low Risk
Low risk refactor limited to sqlite error construction; behavior should be unchanged aside from slightly different call sites for error classification.

Overview
Removes the local classifyError helper in NodeSqliteClient and inlines classifySqliteError at each statement prepare/execute failure site.

This is a small refactor that keeps the same error messages/operations while making the error-classification calls explicit where SqlError is created.

Written by Cursor Bugbot for commit 774bd62. This will update automatically on new commits. Configure here.

Note

Inline classifySqliteError calls in NodeSqliteClient by removing local helper

Removes the local classifyError wrapper in NodeSqliteClient.ts and replaces its three call sites with direct calls to classifySqliteError(cause, { message, operation }). No logic or behavior changes.

Macroscope summarized 774bd62.

- Remove the local wrapper helper
- Call `classifySqliteError` directly at each failure site
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 29, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: e295c98d-b0b1-42f5-b79c-f791d4778084

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/inline-sqlite-error-classification

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Mar 29, 2026
@juliusmarminge juliusmarminge enabled auto-merge (squash) March 29, 2026 05:54
@juliusmarminge juliusmarminge merged commit bc1024c into main Mar 29, 2026
11 checks passed
@juliusmarminge juliusmarminge deleted the feature/inline-sqlite-error-classification branch March 29, 2026 05:55
sfncore pushed a commit to sfncore/t3code that referenced this pull request Mar 29, 2026
Upstream changes (v0.0.15):
- Refactor projection pipeline side effects (pingdotgg#1512)
- Inline sqlite error classification (pingdotgg#1515)
- DrainableWorker drain off outstanding count (pingdotgg#1514)
- Thread archiving with archivedAt (pingdotgg#1505-related migrations)
- Auto-generate first-turn thread titles (pingdotgg#1375)
- Keyboard shortcuts for sidebar threads (pingdotgg#1456)
- Various UI fixes (sidebar, settings, markdown links)

Conflict resolution:
- ProjectionPipeline.ts: took upstream (our REINDEX workaround
  no longer needed with doltlite canDefer=0 fix)
- Migrations.ts: renumbered our 016-018 to 019-021, keeping
  upstream's 016-018 (CanonicalizeModelSelections, ArchivedAt)
- ProjectionThreads.ts, orchestration.ts: took upstream (archiving)
- Sidebar files: took upstream (new features)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
AustinKelsay pushed a commit to AustinKelsay/t3code-custom that referenced this pull request Mar 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant