Skip to content

Conversation

@dveeden
Copy link

@dveeden dveeden commented Oct 29, 2024

No description provided.

Copy link

@gregwebs gregwebs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using https://github.com/gregwebs/errors that I have been updating and maintaining.
It has some breaking changes compared to pingcap/errors but the most commonly used functions are still just the same.


require (
github.com/davecgh/go-spew v1.1.1 // indirect
github.com/pmezard/go-difflib v1.0.0 // indirect

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is all this from?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From go mod tidy. go mod graph should be able to tell you more about the content

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are all from testify. Its a pitty that testing dependencies are always pulled for every go project and not kept separate. In my fork I didn't update to a better testing library for this reason. I am also trying out github.com/shoenig/test which has similar functionality as testify but only pulls in github.com/google/go-cmp

module github.com/pingcap/errors

go 1.14
go 1.21

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good for a library to keep a lower go mod version if it doesn't need a newer one.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants