test: fix potential timeout - #79
Merged
Merged
Conversation
wesleytodd
pushed a commit
to wesleytodd/router
that referenced
this pull request
Jan 5, 2020
The default timeout for one test was too low in case the test was run from a slow machine. This increases the timeout to 4 seconds.
dougwilson
force-pushed
the
fix-timeout
branch
from
January 24, 2020 05:44
4bd5d04 to
1813f0c
Compare
dougwilson
approved these changes
Jan 24, 2020
dougwilson
left a comment
Contributor
There was a problem hiding this comment.
my humble apologies for sitting on this pr and thank you very much for making it. this will be in a tagged version on master soon, which i believe is what citgm needs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default timeout for one test was too low in case the test was
run from a slow machine. This increases the timeout to 4 seconds.
Refs: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1758/nodes=aix61-ppc64/testReport/junit/(root)/citgm/router_v1_3_3/