refactor(diffs): rename Editor to Edit / @pierre/diffs/editor to @pierre/diffs/edit#977
Open
mdo wants to merge 2 commits into
Open
refactor(diffs): rename Editor to Edit / @pierre/diffs/editor to @pierre/diffs/edit#977mdo wants to merge 2 commits into
mdo wants to merge 2 commits into
Conversation
…rre/diffs/edit Rebrand the "editor mode" surface to "edit mode". Rename the public entry point @pierre/diffs/editor -> @pierre/diffs/edit, the Editor class -> Edit, and sweep all edit-mode identifiers (EditorOptions, EditorSelection, DiffsEditor, createEditor, getEditor, useEditor, EditProvider `editor` prop, etc.) to their Edit* equivalents across src, tests, apps, and docs. - Move packages/diffs/src/editor/ -> src/edit/ (editor.ts/.css -> edit.ts/.css) and update package.json exports (./editor -> ./edit) - Rename test/editor*.test.ts -> edit*.test.ts and update e2e fixtures - Rename docs Editor page -> Edit (docs/Editor -> docs/Edit, EditorDemo -> EditDemo, LiveEditor/LiveDiffEditor examples) and refresh prose - Regenerate the AUI homepage mock-data snapshot from updated sources Preserves external theme-spec tokens (editor.background, editorCursor.*, ...), internal DOM/CSS contracts (data-editor-*, --diffs-editor-* vars, diffs-editor-icon-* sprite IDs), and generic IDE/text-editor references.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
|
I wonder if we should wait till right before the stable release to do this, that way to reduce potential bug fix thrash and stuff? |
Contributor
Author
|
Fine by me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebrand the "editor mode" surface to "edit mode". Rename the public entry point @pierre/diffs/editor -> @pierre/diffs/edit, the Editor class -> Edit, and sweep all edit-mode identifiers (EditorOptions, EditorSelection, DiffsEditor, createEditor, getEditor, useEditor, EditProvider
editorprop, etc.) to their Edit* equivalents across src, tests, apps, and docs.Preserves external theme-spec tokens (editor.background, editorCursor., ...), internal DOM/CSS contracts (data-editor-, --diffs-editor-* vars, diffs-editor-icon-* sprite IDs), and generic IDE/text-editor references.