Skip to content

Allow high contrast themes for WEBTHEME #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PromoFaux merged 1 commit into from
May 28, 2023
Merged

Allow high contrast themes for WEBTHEME #1338

PromoFaux merged 1 commit into from
May 28, 2023

Conversation

@rdwebdesign
Copy link
Member

@rdwebdesign rdwebdesign commented Mar 23, 2023 •
edited
Loading

Description

Fix #1337

Motivation and Context

The validation function wasn't allowing the recently introduced themes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-advanced-security
Copy link

github-advanced-security bot commented Mar 23, 2023

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@rdwebdesign rdwebdesign requested a review from PromoFaux March 23, 2023 17:36
@rdwebdesign rdwebdesign requested a review from a team April 4, 2023 21:55
@PromoFaux PromoFaux merged commit c470b10 into dev May 28, 2023
@PromoFaux PromoFaux deleted the add_new_web_themes branch May 28, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PromoFaux PromoFaux PromoFaux approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rdwebdesign @PromoFaux