Fix MutatingScope->compareVariableTypeHolders() #4641
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This pull request has been marked as ready for review. |
staabm
commented
Dec 19, 2025
| unset($otherVariableTypeHolders[$variableExprString]); | ||
| } | ||
|
|
||
| if (count($otherVariableTypeHolders) > 0) { |
Contributor
Author
There was a problem hiding this comment.
in the loop this array is reduced one offset at a time, which only makes sense if we check afterwards whether $otherVariableTypeHolders contained elements which were not contained in $variableTypeHolders
Member
There was a problem hiding this comment.
Can you write a failing test against this? Or is it just about performance?
Contributor
Author
There was a problem hiding this comment.
yeah, I think I need to come up with a test. looks like a bug to me.
not perf related, just stumbled over it, while looking into #4640 (comment)
ondrejmirtes
requested changes
Dec 19, 2025
| unset($otherVariableTypeHolders[$variableExprString]); | ||
| } | ||
|
|
||
| if (count($otherVariableTypeHolders) > 0) { |
Member
There was a problem hiding this comment.
Can you write a failing test against this? Or is it just about performance?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.