Skip to content

(fix): exception will never be a int#16

Merged
veewee merged 1 commit intophpro:masterfrom
lucassabreu:master
Jul 8, 2021
Merged

(fix): exception will never be a int#16
veewee merged 1 commit intophpro:masterfrom
lucassabreu:master

Conversation

@lucassabreu
Copy link
Contributor

Q A
Type bug
BC Break no
Fixed issues

Summary

Status and Status Code will never be other than 500, because the code is trying to assert that a \Throwable is a int

@lucassabreu lucassabreu marked this pull request as ready for review July 8, 2021 18:07
@veewee
Copy link
Contributor

veewee commented Jul 8, 2021

Aw, that's painfull 😅

Thanks for noticing!

@veewee veewee added the bug Something isn't working label Jul 8, 2021
@veewee veewee added this to the 1.4.2 milestone Jul 8, 2021
@veewee veewee merged commit 46fdf98 into phpro:master Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants