Adds a toggle to allow shape files with no dbf#41
Merged
MauricioFauth merged 2 commits intoDec 8, 2024
Conversation
JoolsMcFly
marked this pull request as draft
November 19, 2024 21:47
JoolsMcFly
force-pushed
the
feature/36-allow-no-dbf
branch
from
November 19, 2024 22:00
fa57fb1 to
09610f5
Compare
JoolsMcFly
marked this pull request as ready for review
November 19, 2024 22:04
JoolsMcFly
commented
Nov 19, 2024
MauricioFauth
approved these changes
Dec 8, 2024
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
MauricioFauth
added a commit
that referenced
this pull request
Dec 8, 2024
[ci skip] Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi.
This PR fixes #36 as it gives users the ability to process a shape file with no matching dbf file.
A call to $shp->setAllowNoDbf(true); does the trick.
I left open the PR targeting master because
3.1.xandmasterbranches are different enough (no psalm, use of ShapeFile enum etc) to have me change code from my first PR to make it work in3.1.x.Thanks for reviewing.