make frankenphp directive optional, thanks @francislavoie#1601
Merged
make frankenphp directive optional, thanks @francislavoie#1601
Conversation
Contributor
|
I didn't realize a global variable was being used here This can be gotten rid of by having each handler instance call methods on the app instance in So like: app, err := ctx.App("frankenphp")
if err != nil {
return err
}
app.AddWorkerConfig(...)It's not right at all that |
Contributor
Author
|
edit : resolved |
dunglas
requested changes
May 23, 2025
AlliBalliBaba
approved these changes
May 31, 2025
withinboredom
approved these changes
May 31, 2025
dunglas
approved these changes
Jun 2, 2025
Member
|
Excellent work. Thanks! |
henderkes
added a commit
to mhpcc/frankenphp
that referenced
this pull request
Jun 5, 2025
* make frankenphp directive optional, thanks @francislavoie * get rid of global variable * update workers when adding to app * suggestions * goto instead of continue outer? * remove empty frankenphp directives * update config to reflect the optional frankenphp directive * AI translations * restore eol newlines * don't double check for duplicate worker name * add short form for php_server worker too * translations * AI hates EOL newlines now? * suggestion to check for nil * suggestion to use else if block
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.