PLP-26: Update Grid for Container Fluid#191
Merged
illepic merged 1 commit intofeature/v10/PLP-28-drupal_articlefrom Dec 18, 2017
Merged
PLP-26: Update Grid for Container Fluid#191illepic merged 1 commit intofeature/v10/PLP-28-drupal_articlefrom
illepic merged 1 commit intofeature/v10/PLP-28-drupal_articlefrom
Conversation
anniegreens
approved these changes
Dec 14, 2017
illepic
suggested changes
Dec 16, 2017
| <div class="row"> | ||
| <div class="col"> | ||
| {% block column_1 %}{% endblock column_1 %} | ||
| {% set container_class = container ? 'container' : (container_fluid ? 'container-fluid') %} |
Contributor
There was a problem hiding this comment.
How can we do this with twig filters? And if not twig filters then more use of ?:.
Contributor
Author
There was a problem hiding this comment.
I wanted this to be explicit to avoid refactoring usages of our grid embeds elsewhere, since we have a ton of with { container: true } throughout. This way it works as:
- No value
with { container: true }with { container_fluid: true }
I think it's ugly in this template for the payoff of it being easier to use. FWIW.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates Grid to allow for
container-fluidor empty values (no grid) without changing how grid / layouts themselves work.