Skip to content

[BUGFIX] Dashboard: remove unmountOnExit flag of the row collapse #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgbernalp merged 1 commit into from
Apr 14, 2026
Merged

[BUGFIX] Dashboard: remove unmountOnExit flag of the row collapse #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions dashboards/src/components/GridLayout/GridItemContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

import { Box } from '@mui/material';
import { Box, useForkRef } from '@mui/material';
import { useInView } from 'react-intersection-observer';
import { DataQueriesProvider, usePlugin, useSuggestedStepMs } from '@perses-dev/plugin-system';
import React, { ReactElement, useMemo, useState } from 'react';
Expand Down Expand Up @@ -40,12 +40,21 @@ export function GridItemContent(props: GridItemContentProps): ReactElement {
const { isEditMode } = useEditMode();
const { openEditPanel, openDeletePanelDialog, duplicatePanel, viewPanel } = usePanelActions(panelGroupItemId);
const viewPanelGroupItemId = useViewPanelGroup();
const { ref, inView } = useInView({
threshold: 0.2, // we have the flexibility to adjust this threshold to trigger queries slightly earlier or later based on performance

const { ref: queryRef, inView: shouldQuery } = useInView({
threshold: 0,
initialInView: false,
triggerOnce: true,
});

const { ref: renderRef, inView: shouldRender } = useInView({
threshold: 0.2,
initialInView: false,
triggerOnce: false,
});

const mergedRef = useForkRef(renderRef, queryRef);

const [openQueryViewer, setOpenQueryViewer] = useState(false);

const viewQueriesHandler = useMemo(() => {
Expand Down Expand Up @@ -99,7 +108,7 @@ export function GridItemContent(props: GridItemContentProps): ReactElement {

return (
<Box
ref={ref}
ref={mergedRef}
sx={{
width: '100%',
height: '100%',
Expand All @@ -108,9 +117,9 @@ export function GridItemContent(props: GridItemContentProps): ReactElement {
<DataQueriesProvider
definitions={definitions}
options={{ suggestedStepMs, ...pluginQueryOptions }}
queryOptions={{ enabled: inView }}
queryOptions={{ enabled: shouldQuery }}
>
{inView && (
{shouldRender && (
<Panel
definition={panelDefinition}
readHandlers={readHandlers}
Expand Down
Loading