[GH-6765] Linter should fail if baseline no longer relevent#20
Conversation
| @@ -0,0 +1,32 @@ | |||
| RSpec::Matchers.define :be_empty_with_exceptions do |custom_message=nil, allowlist: nil, baseline: nil| | |||
There was a problem hiding this comment.
Shouldn't we also do the same for be_true and be_false?
We could also update the existing matchers to accept an optional allowlist and baseline, instead of having different matchers.
There was a problem hiding this comment.
Also, how would this work with different types of baseline?
For example, sometimes we have a baseline of classes, or baseline of files, or baseline of method names, etc.
There was a problem hiding this comment.
It works with classes / and filenames because it check against each of the fields... Sorry this should of still been a draft
There was a problem hiding this comment.
What about be_true and be_false?
There was a problem hiding this comment.
If we truly have no consumer for the be_true and be_false` matchers with baselines, then I am ok pushing this to a future PR.
There was a problem hiding this comment.
Why don't we update the existing matchers to add an optional param of baseline? Wouldn't this be more consistent with the existing API?
| class ModulesCollection < BaseCollection | ||
| include Rubyzen::Providers::CollectionFilterProvider | ||
|
|
||
| def all_methods |
There was a problem hiding this comment.
nit: check if classes collection is doing this and has same name
Bastian (bkoell)
left a comment
There was a problem hiding this comment.
Merge and tag this Rubyzen release. Then update the version tag in a Husband-Redis PR and merge.
[GH-6765] Linter should fail if baseline no longer relevent