Skip to content

🐛 Start server after launching a browser and creating a build #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wwilsman merged 2 commits into from
Nov 9, 2020
Merged

🐛 Start server after launching a browser and creating a build #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b308c0d
🐛 Start server after launching a browser and creating a build
wwilsman Nov 9, 2020
20ac962
🚨 Relax certain lint errors in tests
wwilsman Nov 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/core/src/percy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,13 +90,13 @@ export default class Percy {
this.client.getToken();

try {
// if there is a server, start listening
await this.server?.listen(this.port);

// launch the discoverer browser and create a percy build
await this.discoverer.launch();
await this.client.createBuild();

// if there is a server, start listening
await this.server?.listen(this.port);

// log build details
let build = this.client.build;
let meta = { build: { id: build.id } };
Expand All @@ -106,9 +106,9 @@ export default class Percy {
// mark this process as running
this.#running = true;
} catch (error) {
// on error, close any running browser or server
await this.discoverer.close();
// on error, close any running server or browser
await this.server?.close();
await this.discoverer.close();

// throw an easier-to understand error when the port is taken
if (error.code === 'EADDRINUSE') {
Expand Down
3 changes: 3 additions & 0 deletions packages/core/test/.eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
env:
mocha: true
rules:
no-return-assign: off
no-sequences: off
20 changes: 18 additions & 2 deletions packages/core/test/percy.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,11 @@ describe('Percy', () => {
});

describe('#start()', () => {
it('launches a browser', async () => {
await expect(percy.start()).resolves.toBeUndefined();
expect(percy.discoverer.isConnected()).toBe(true);
});

it('creates a build', async () => {
await expect(percy.start()).resolves.toBeUndefined();
expect(mockAPI.requests['/builds']).toBeDefined();
Expand All @@ -115,9 +120,20 @@ describe('Percy', () => {
await expect(fetch('http://localhost:5338')).resolves.toBeDefined();
});

it('connects to a browser instance', async () => {
it('starts a server after launching a browser and creating a build', async () => {
let launch = percy.discoverer.launch.bind(percy.discoverer);
let create = percy.client.createBuild.bind(percy.client);
let start = percy.server.listen.bind(percy.server);
let launched, created, started;

percy.discoverer.launch = () => (launched = Date.now(), launch());
percy.client.createBuild = () => (created = Date.now(), create());
percy.server.listen = () => (started = Date.now(), start());

await expect(percy.start()).resolves.toBeUndefined();
expect(percy.discoverer.isConnected()).toBe(true);

expect(launched).toBeLessThan(created);
expect(created).toBeLessThan(started);
});

it('does not error or launch multiple browsers', async () => {
Expand Down