Skip to content

Revert PER-9560 CI changes — restore original test/windows workflows#2298

Merged
ninadbstack merged 1 commit into
masterfrom
PER-9560_revert-ci-changes
Jun 17, 2026
Merged

Revert PER-9560 CI changes — restore original test/windows workflows#2298
ninadbstack merged 1 commit into
masterfrom
PER-9560_revert-ci-changes

Conversation

@AkashBrowserStack

Copy link
Copy Markdown
Contributor

Summary

Reverts the PER-9560 CI changes made this session — restores .github/workflows/test.yml and windows.yml to their pre-PER-9560 state.

Net diff is just removing the paths-ignore block from both workflows (added in #2293):

   pull_request:
-    paths-ignore:
-      - 'lerna.json'
-      - 'packages/*/package.json'
   workflow_dispatch:

#2293 had already reverted #2284's machinery (the changes job, the version_only / github-actions[bot] gate, and the permissions block), so removing the path filter restores the original workflows exactly.

Effect: version-bump PRs will once again run the full Linux + Windows test suites — i.e., PER-9560 is fully backed out. No other behavior change.

Reverts

🤖 Generated with Claude Code

Restores .github/workflows/test.yml and windows.yml to their pre-PER-9560
state. Removes the paths-ignore filter (added in #2293) — which had already
reverted the job-level skip / changes job / version_only + github-actions[bot]
gate / permissions block from #2284.

Net effect: every workflow change made for PER-9560 this session is undone;
version-bump PRs once again run the full Linux + Windows test suites as before.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@AkashBrowserStack AkashBrowserStack requested a review from a team as a code owner June 17, 2026 07:24
@AkashBrowserStack AkashBrowserStack added the 🧹 maintenance General maintenance label Jun 17, 2026
@AkashBrowserStack

Copy link
Copy Markdown
Contributor Author

🤖 Claude Code Review — stack:pr-review

PR: #2298Head: 0a8fc03Reviewers: stack:percy-cli-code-reviewer (harness percy-cli stack) + inline 18-row checklist

Summary: Pure −6-line revert — removes the on.pull_request.paths-ignore block (lerna.json, packages/*/package.json) from test.yml and windows.yml, restoring them to their pre-PER-9560 state. Backs out the PER-9560 work (#2284 → reverted by #2293 → path filter removed here); version-bump PRs once again run the full Linux + Windows suites. Deletion-only, no additions.

Priority Category Check Status Notes
High Security No hardcoded secrets / credentials ✅ Pass Deletions only; pre-existing secrets.PERCY_REGRESSION_TOKEN untouched
High Security Authn/authz checks present N/A Workflow config
High Security Input validation / sanitization ✅ Pass Nothing added; no injection surface
High Security No IDOR N/A
High Security No SQL injection N/A
High Correctness Logic correct, edge cases handled ✅ Pass Only the 3-line paths-ignore removed per file; build/test/regression jobs, matrix, and PER-9011 retry logic unchanged; effect is stricter CI (full suite runs again), not looser
High Correctness Explicit error handling N/A No runtime logic changed
High Correctness No race/concurrency issues N/A
Medium Testing New code has tests N/A CI config — restores a previously-shipped state
Medium Testing Error/edge paths tested N/A
Medium Testing Existing tests still pass ✅ Pass No test logic changed
Medium Performance No N+1 / unbounded fetch N/A
Medium Performance Long tasks backgrounded N/A
Medium Quality Follows codebase patterns ✅ Pass Restored on: block matches standard repo trigger style; valid YAML
Medium Quality Focused (single concern) ✅ Pass Two workflow files, deletions only
Low Quality Meaningful names, no dead code ✅ Pass Removes the path filter cleanly; no remnants
Low Quality Comments explain why ✅ Pass N/A — no comments involved
Low Quality No unnecessary deps N/A

Findings: No blocking findings. Scope verified — git diff --name-status shows only the two workflow files (6 deletions, 0 additions); no paths-ignore/version_only/changes:/permissions: remnants.


Verdict: PASS

@ninadbstack ninadbstack merged commit d86817b into master Jun 17, 2026
63 of 64 checks passed
@ninadbstack ninadbstack deleted the PER-9560_revert-ci-changes branch June 17, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧹 maintenance General maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants