Revert PER-9560 CI changes — restore original test/windows workflows#2298
Merged
Conversation
Restores .github/workflows/test.yml and windows.yml to their pre-PER-9560 state. Removes the paths-ignore filter (added in #2293) — which had already reverted the job-level skip / changes job / version_only + github-actions[bot] gate / permissions block from #2284. Net effect: every workflow change made for PER-9560 this session is undone; version-bump PRs once again run the full Linux + Windows test suites as before. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
pranavz28
approved these changes
Jun 17, 2026
Contributor
Author
🤖 Claude Code Review —
|
| Priority | Category | Check | Status | Notes |
|---|---|---|---|---|
| High | Security | No hardcoded secrets / credentials | ✅ Pass | Deletions only; pre-existing secrets.PERCY_REGRESSION_TOKEN untouched |
| High | Security | Authn/authz checks present | N/A | Workflow config |
| High | Security | Input validation / sanitization | ✅ Pass | Nothing added; no injection surface |
| High | Security | No IDOR | N/A | — |
| High | Security | No SQL injection | N/A | — |
| High | Correctness | Logic correct, edge cases handled | ✅ Pass | Only the 3-line paths-ignore removed per file; build/test/regression jobs, matrix, and PER-9011 retry logic unchanged; effect is stricter CI (full suite runs again), not looser |
| High | Correctness | Explicit error handling | N/A | No runtime logic changed |
| High | Correctness | No race/concurrency issues | N/A | — |
| Medium | Testing | New code has tests | N/A | CI config — restores a previously-shipped state |
| Medium | Testing | Error/edge paths tested | N/A | — |
| Medium | Testing | Existing tests still pass | ✅ Pass | No test logic changed |
| Medium | Performance | No N+1 / unbounded fetch | N/A | — |
| Medium | Performance | Long tasks backgrounded | N/A | — |
| Medium | Quality | Follows codebase patterns | ✅ Pass | Restored on: block matches standard repo trigger style; valid YAML |
| Medium | Quality | Focused (single concern) | ✅ Pass | Two workflow files, deletions only |
| Low | Quality | Meaningful names, no dead code | ✅ Pass | Removes the path filter cleanly; no remnants |
| Low | Quality | Comments explain why | ✅ Pass | N/A — no comments involved |
| Low | Quality | No unnecessary deps | N/A | — |
Findings: No blocking findings. Scope verified — git diff --name-status shows only the two workflow files (6 deletions, 0 additions); no paths-ignore/version_only/changes:/permissions: remnants.
Verdict: PASS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts the PER-9560 CI changes made this session — restores
.github/workflows/test.ymlandwindows.ymlto their pre-PER-9560 state.Net diff is just removing the
paths-ignoreblock from both workflows (added in #2293):#2293 had already reverted #2284's machinery (the
changesjob, theversion_only/github-actions[bot]gate, and thepermissionsblock), so removing the path filter restores the original workflows exactly.Effect: version-bump PRs will once again run the full Linux + Windows test suites — i.e., PER-9560 is fully backed out. No other behavior change.
Reverts
ci: skip heavy test suites on bot version-bump PRsci: skip heavy suites on version-bump PRs via paths-ignore🤖 Generated with Claude Code