PG-2219 - Update install, yum and apt.md#519
Merged
Conversation
This PR updates the variable for pg version from minor to major versions and fixes incorrect pg_tde package mentions
Aligned label version update with current release version numbers to not conflict when merged
jeltz
requested changes
Mar 3, 2026
| ``` | ||
|
|
||
| ### Example for PostgreSQL 17 | ||
| ### Example for PostgreSQL 18 |
Collaborator
There was a problem hiding this comment.
Shouldn't you use the variable here too?
Collaborator
Author
There was a problem hiding this comment.
We could, sure, however if we do then for 19 (when it appears) we have to be sure the example is still up to date with that version.
Rarely, variable usage for example cases are harder to identify when used, to me personally it seems easier to manually review the documentation for 18 mentions for specific cases like examples if that makes sense instead of searching for {variablenr} in the whole doc.
jeltz
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the variable for pg version from minor to major versions and fixes incorrect pg_tde package mentions