enable bnb chain #655
Merged
Merged
Conversation
…d of .pendulumDecimals)
✅ Deploy Preview for pendulum-pay ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables BNB Smart Chain support and aligns chain-specific decimals in both shared configs and the UI.
- Activates BSC token configuration and network metadata
- Integrates BSC into the frontend transport and icon mappings
- Updates UI text and timing for the
brlaTeleportphase
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| shared/src/tokens/evm/config.ts | Uncommented and restructured BSC EvmToken entries |
| shared/src/helpers/networks.ts | Enabled BSC in the Networks enum and metadata |
| frontend/src/wagmiConfig.ts | Imported bsc, added Alchemy transport for BSC |
| frontend/src/translations/pt.json | Updated Portuguese brlaTeleport message |
| frontend/src/translations/en.json | Updated English brlaTeleport message |
| frontend/src/pages/progress/index.tsx | Changed brlaTeleport phase duration to 5 minutes |
| frontend/src/hooks/useGetNetworkIcon.tsx | Added BSC icon mapping |
| api/src/api/services/ramp/quote.service.ts | Switched to chain-defined decimals, removed ! |
| api/src/api/helpers/contracts.ts | Consolidated and relocated utility functions |
| api/.eslintrc.js | Disabled class-methods-use-this rule |
Comments suppressed due to low confidence (1)
frontend/src/wagmiConfig.ts:34
- The
networksarray is missingbsc, so the BNB Smart Chain won't be available in the frontend. Please addbscto this list.
const networks = [mainnet, polygon, arbitrum, base, avalanche];
| }, | ||
| [EvmToken.USDCE]: { | ||
| assetSymbol: 'USDC.e', | ||
| erc20AddressSourceChain: '0x2791bca1f2de4661ed88a30c99a7a9449aa84174', // Placeholder, update with actual address |
There was a problem hiding this comment.
[nitpick] This placeholder address for USDCE should be replaced with the final contract address or clearly tracked as a TODO to avoid deploying incorrect data.
Suggested change
| erc20AddressSourceChain: '0x2791bca1f2de4661ed88a30c99a7a9449aa84174', // Placeholder, update with actual address | |
| erc20AddressSourceChain: '0x2791bca1f2de4661ed88a30c99a7a9449aa84174', // TODO: Replace with the actual contract address for USDCE |
| '0x30a300612ab372cc73e53ffe87fb73d62ed68da3', // It does not matter. | ||
| amountOut.preciseQuotedAmountOut.rawBalance.toFixed(), | ||
| outTokenDetails!, | ||
| outTokenDetails, |
There was a problem hiding this comment.
You removed the non-null assertion on outTokenDetails, which may now be undefined here. Consider adding a runtime null check or a guard clause before passing it to createOnrampRouteParams.
…rtex into chore/enable-bnb-chain
ebma
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.