Skip to content

Updating Navbar #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
prayagd wants to merge 4 commits into from
Closed

Updating Navbar #543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5c5a71f
Updating Navbar
prayagd Apr 2, 2025
4e7bf9e
Update pt.json
prayagd Apr 2, 2025
2913a9f
Links updated
prayagd Apr 2, 2025
9efed52
link fixed
prayagd Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/components/Navbar/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,9 @@ const Links = () => {
const { t } = useTranslation();

const links = [
{ title: t('components.navbar.sellCrypto'), href: '/' },
{ title: t('components.navbar.howItWorks'), href: 'https://www.vortexfinance.co/#lowest-code' },
{ title: t('components.navbar.community'), href: 'https://www.vortexfinance.co/#call-to-action' },
{ title: t('components.navbar.support'), href: 'https://pendulum.gitbook.io/vortex/support-and-contact' },
{ title: t('components.navbar.docs'), href: 'https://pendulum.gitbook.io/vortex' },
{ title: t('components.navbar.faq'), href: 'https://app.vortexfinance.co/#faq' },
Copy link
Copy Markdown
Member

@ebma ebma Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the expected behavior for clicking on the FAQ link? Do you want it to scroll down on the same page or open a new page?

Copy link
Copy Markdown
Member Author

@prayagd prayagd Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scroll down to the same page to the faq section

Copy link
Copy Markdown
Member

@ebma ebma Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work in that case then. For one, you are always putting the production address so on deploy previews etc. it will always open a new page. If you feel like it, feel free to try troubleshooting it yourself with AI. Otherwise one of the @pendulum-chain/devs needs to add that before we can merge.

Copy link
Copy Markdown
Member Author

@prayagd prayagd Apr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok let me give a try

];

return (
Expand Down
6 changes: 3 additions & 3 deletions src/translations/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,9 +214,9 @@
"signatures": "Signatures"
},
"navbar": {
"sellCrypto": "Sell Crypto",
"howItWorks": "How it works",
"community": "Community"
"support": "Support",
"docs": "Docs",
"faq": "FAQ"
},
"swap": {
"sellCrypto": "Sell",
Expand Down
6 changes: 3 additions & 3 deletions src/translations/pt.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,9 +213,9 @@
"signatures": "Assinaturas"
},
"navbar": {
"sellCrypto": "Vender Cripto",
"howItWorks": "Como funciona",
"community": "Comunidade"
"support": "Suporte",
"docs": "Docs",
"faq": "FAQ"
},
"swap": {
"sellCrypto": "Vender Cripto",
Expand Down