[READY] fix: assethubToPendulum transaction being filtered out when EVM wallet#1049
Merged
ebma merged 4 commits intoJan 30, 2026
Merged
Conversation
✅ Deploy Preview for vortex-sandbox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vortexfi ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ebma
reviewed
Jan 30, 2026
| const signerAddress = executionInput?.moneriumWalletAddress || connectedWalletAddress; | ||
| // For substrate networks (Pendulum/AssetHub), always use connectedWalletAddress. | ||
| // moneriumWalletAddress is only for Monerium flows with EVM transactions. | ||
| const isSubstrateTransaction = tx.network === Networks.Pendulum || tx.network === Networks.AssetHub; |
Member
There was a problem hiding this comment.
What do you think about, instead of checking per network, we check with the transaction data itself? This seems a little more robust to me because otherwise we'd have to touch this check in the future for other substrate networks.
ebma
approved these changes
Jan 30, 2026
ebma
left a comment
Member
There was a problem hiding this comment.
I added two small improvements and tested if I'm requested to sign. Works as expected 🆗
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
When a user initiated EUR SELL (offramp) from AssetHub while having an EVM wallet connected, the signing flow failed with:
Root Cause
In
sign.actor.ts:57, the transaction filter always usedmoneriumWalletAddress(an EVM address) when available:Since DetailsStep always sets moneriumWalletAddress: evmAddress in the form (even for non-Monerium flows), the filter would compare an EVM address against Substrate transaction signers. This comparison always failed, filtering out the
assethubToPendulumtransaction.Solution
Use the connected Substrate wallet address for Substrate transactions (Pendulum/AssetHub), and only use moneriumWalletAddress for EVM transactions:
Test plan