Skip to content

feat(cli): -f/--file prompt-file support (llama.cpp-compatible) #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pekkah merged 2 commits into from
Jun 13, 2026
Merged

feat(cli): -f/--file prompt-file support (llama.cpp-compatible) #233

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb30efb
feat(cli): -f/--file prompt-file support (llama.cpp-compatible)
pekkah Jun 13, 2026
8af6234
review(#233): escape path in error + handle prompt-file read failures…
pekkah Jun 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 28 additions & 1 deletion src/SharpInference.Cli/RunCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,11 @@ public sealed class Settings : CommandSettings

[CommandOption("-p|--prompt")]
[Description("Input prompt (default: interactive chat)")]
public string? Prompt { get; init; }
public string? Prompt { get; set; }

[CommandOption("-f|--file")]
[Description("Read the prompt from a file (llama.cpp -f/--file). Overrides -p when both are given; useful for prompts longer than the shell's command-line limit.")]
public string? PromptFile { get; init; }

[CommandOption("-n|--n-predict")]
[Description("Number of tokens to predict (default: 512)")]
Expand Down Expand Up @@ -188,6 +192,29 @@ public sealed class Settings : CommandSettings

protected override int Execute(CommandContext context, Settings settings, CancellationToken cancellation)
{
// --file/-f (llama.cpp): load the prompt from a file. Overrides -p; lets prompts exceed
// the shell command-line length limit. Read as-is (no trailing-newline stripping).
if (settings.PromptFile is { Length: > 0 } promptFile)
{
if (!File.Exists(promptFile))
{
AnsiConsole.MarkupLine($"[red]Prompt file not found:[/] {Markup.Escape(promptFile)}");
return 1;
}
// Read failures (locked file, permissions, bad path) should fail loud + clean, not
// throw a stack trace; Escape the message since paths can carry Spectre markup chars.
try
{
settings.Prompt = File.ReadAllText(promptFile);
}
catch (Exception ex) when (ex is IOException or UnauthorizedAccessException
or System.Security.SecurityException or NotSupportedException)
{
AnsiConsole.MarkupLine($"[red]Error reading prompt file:[/] {Markup.Escape(ex.Message)}");
return 1;
}
}
Comment on lines +197 to +216

@gemini-code-assist gemini-code-assist Bot Jun 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There are two issues in this block:

  1. Spectre.Console Markup Parsing Error: If promptFile contains square brackets (e.g., [path]), AnsiConsole.MarkupLine will attempt to parse it as markup, leading to incorrect rendering or exceptions. Use Markup.Escape(promptFile) to prevent this.
  2. Unhandled I/O Exceptions: File.ReadAllText can throw exceptions (e.g., UnauthorizedAccessException, IOException) if the file is locked or permissions are insufficient. Wrapping it in a try-catch block ensures the CLI exits gracefully with a clean error message instead of crashing with a stack trace.
        if (settings.PromptFile is { Length: > 0 } promptFile)
        {
            if (!File.Exists(promptFile))
            {
                AnsiConsole.MarkupLine($"[red]Prompt file not found:[/] {Markup.Escape(promptFile)}");
                return 1;
            }
            try
            {
                settings.Prompt = File.ReadAllText(promptFile);
            }
            catch (Exception ex)
            {
                AnsiConsole.MarkupLine($"[red]Error reading prompt file:[/] {Markup.Escape(ex.Message)}");
                return 1;
            }
        }

@pekkah pekkah Jun 13, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed: Markup.Escape on both the not-found and read-error messages, and File.ReadAllText is wrapped in try/catch (IOException/UnauthorizedAccessException/SecurityException/NotSupportedException) → clean message + exit 1. Verified a bracketed missing path renders correctly.


if (settings.MinBatchBlas > 0)
SimdKernels.MinBatchForBlas = settings.MinBatchBlas;

Expand Down