Conversation
index.js
Outdated
|
Can the test262 tests not be brought in as an Also, please feel free to look at the |
|
@ljharb I wish we could! Test262 is not based on Mocha. I just wrote a thin wrapper and modified a couple of tests to make it work in Mocha+Node. |
Also fix a typo and remove an unnecessary part of the tests.
index.js
Outdated
There was a problem hiding this comment.
Should this just be length <= 0 to optimize the negative length case?
Also, instead of return undefined;, can this just be return;?
There was a problem hiding this comment.
Actually, now that the typeof test is done before we could even remove this early exit.
There was a problem hiding this comment.
Sure, it'd be functionally equivalent, but it's nice to optimize for code paths when it's easy :-)
|
What is needed from bterlson/test262-harness to make it work for this project? |
|
The changes to the implementation have been applied in master:
|
|
@juandopazo would you mind freshly rebasing this on top of master so it can be reconsidered? |
Hi!
Here are some changes based on the latest spec changes:
ToUint32. Instead, they useToLengthwhich makes much more sense.