feat(page components): remove sticky prop#185
Merged
Conversation
c585bde to
e45aff2
Compare
This was
linked to
issues
Dec 22, 2022
gitdallas
suggested changes
Jan 4, 2023
Contributor
There was a problem hiding this comment.
to be full and match what we've done other places, think we should add the valid tests for more than just PageSection, and non-pf import tests.
if you want you could make the tests take less real estate (and quicker to glance at) by mapping ['PageSection', 'PageNavigation', etc..] into the objects.
Collaborator
thatblindgeye
left a comment
There was a problem hiding this comment.
Other than the above, the only nit I'd have is placing the addition to the README alphabetically.
629b830 to
d76abfb
Compare
fix prop message fix errors syntax PR feedback
d76abfb to
3488374
Compare
thatblindgeye
approved these changes
Jan 10, 2023
gitdallas
approved these changes
Jan 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: