chore(table demos): update filterable demo from deprecated to new table#9055
Conversation
|
Preview: https://patternfly-react-pr-9055.surge.sh A11y report: https://patternfly-react-pr-9055-a11y.surge.sh |
nicolethoen
left a comment
There was a problem hiding this comment.
I see a few things we could clean up while we are tinkering with this demo:
Looks like you can remove the following unused dependencies:
Dropdown,
DropdownItem,
DropdownPosition,
DropdownToggle,
minWidth is being passed twice to the Select on line 1376
filters is not ever used - defined on line 1399
jenny-s51
left a comment
There was a problem hiding this comment.
Thanks @nicolethoen ! updated
There was a problem hiding this comment.
I think MenuToggle and MenuToggleElement need to be imported by your demo.
(BTW, i catch these by trying to open full page demos in a codesandbox when i review them. There are errors right now preventing them from working in a codesandbox - unrelated to your changes - but it still catches these sorts of unused vars and missing imports problems)
There was a problem hiding this comment.
Thank you @nicolethoen - added the missing imports. I'll be double-checking any demo PRs in codesandbox from now on 🙂
Good find on the import path - assigned myself to patternfly/patternfly-org#3525, will be looking into it
I think @evwilkin has done work on updating relative imports in codesandbox imports in the past. So once he's back, he may have good insights here |
What: Closes #9030