Skip to content

fix(search-input): wrapped advanced search in div instead of span #8025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolethoen merged 2 commits into from
Sep 22, 2022
Merged

fix(search-input): wrapped advanced search in div instead of span #8025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
309c7aa
fix(searh-input): wrapped advanced search in div instead of span
mcoker Sep 20, 2022
51e0c3a
chore(search-input): updated snapshots
mcoker Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/react-core/src/components/SearchInput/SearchInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ const SearchInputBase: React.FunctionComponent<SearchInputProps> = ({
if (!!onSearch || attributes.length > 0 || !!onToggleAdvancedSearch) {
if (attributes.length > 0) {
const AdvancedSearch = (
<span>
<div>
<AdvancedSearchMenu
value={value}
parentRef={searchInputRef}
Expand All @@ -375,7 +375,7 @@ const SearchInputBase: React.FunctionComponent<SearchInputProps> = ({
getAttrValueMap={getAttrValueMap}
isSearchMenuOpen={isSearchMenuOpen}
/>
</span>
</div>
);

const AdvancedSearchWithPopper = (
Expand Down
4 changes: 2 additions & 2 deletions ...s/react-core/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ exports[`SearchInput advanced search with custom attributes 1`] = `
</svg>
</button>
</div>
<span
<div
class=""
data-popper-escaped="true"
data-popper-placement="bottom-start"
Expand Down Expand Up @@ -431,7 +431,7 @@ exports[`SearchInput advanced search with custom attributes 1`] = `
</div>
</div>
</div>
</span>
</div>
</div>
</DocumentFragment>
`;
Expand Down