react-styles: Fix .mjs component CSS imports#7971
Merged
Merged
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-7971.surge.sh A11y report: https://patternfly-react-pr-7971-a11y.surge.sh |
mcoker
approved these changes
Sep 13, 2022
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #7960
react-styles creates *.mjs files for bundlers that support them (like create-react-app). Currently they import component css like this:
import('./page.css')which is using the import function. That results in CSS being loaded asynchronously, and can result in the issue above.This PR changes it to be a regular import statement
import './page.css'.Thanks to @mcoker for finding the load ordering issue and providing nice codesandbox examples of what it looks like before and after the react-styles change that introduced the issue
The issue:
Before: The custom stylesheet (index.css) is loaded at the end as expected
After: The custom stylesheet is loaded earlier since the react-core/styles component CSS was loaded lazily
Verified the fix by loading up the user's workspace in issue #7960 , and temporarily changing the react-styles *.mjs CSS imports
Repo that reproduces the issue
https://github.com/jschuler/react-styles-css-load-order