Skip to content

docs(Table): add section about scroll containers#7917

Merged
thatblindgeye merged 1 commit into
patternfly:mainfrom
kmcfaul:table-stickydocs
Sep 1, 2022
Merged

docs(Table): add section about scroll containers#7917
thatblindgeye merged 1 commit into
patternfly:mainfrom
kmcfaul:table-stickydocs

Conversation

@kmcfaul
Copy link
Copy Markdown
Contributor

@kmcfaul kmcfaul commented Sep 1, 2022

What: Closes #7424

Adds a the section about scroll containers (and which are required for what sticky variant) in the top header of the sticky table subsection rather than only mentioning them in each example blurb.

@patternfly-build
Copy link
Copy Markdown
Collaborator

patternfly-build commented Sep 1, 2022

@tlabaj tlabaj requested a review from mcarrano September 1, 2022 17:07
Copy link
Copy Markdown
Member

@mcarrano mcarrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@thatblindgeye thatblindgeye merged commit 05b229f into patternfly:main Sep 1, 2022
@patternfly-build
Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • eslint-plugin-patternfly-react@4.75.3
  • @patternfly/react-catalog-view-extension@4.87.3
  • @patternfly/react-charts@6.89.3
  • @patternfly/react-code-editor@4.77.3
  • @patternfly/react-console@4.87.3
  • @patternfly/react-core@4.236.3
  • @patternfly/react-docs@5.97.3
  • @patternfly/react-icons@4.87.3
  • @patternfly/react-inline-edit-extension@4.81.3
  • demo-app-ts@4.196.3
  • @patternfly/react-integration@4.198.3
  • @patternfly/react-log-viewer@4.81.3
  • @patternfly/react-styles@4.86.3
  • @patternfly/react-table@4.105.3
  • @patternfly/react-tokens@4.88.3
  • @patternfly/react-topology@4.83.3
  • @patternfly/react-virtualized-extension@4.83.3
  • transformer-cjs-imports@4.74.3

Thanks for your contribution! 🎉

andyyvo pushed a commit to andyyvo/patternfly-react that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug - [Composable Table] - [documentation improvement - fixed header]

5 participants