feat(react-styles): parse & update relative imports in css files#7820
Closed
evwilkin wants to merge 2 commits intopatternfly:mainfrom
Closed
feat(react-styles): parse & update relative imports in css files#7820evwilkin wants to merge 2 commits intopatternfly:mainfrom
evwilkin wants to merge 2 commits intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-7820.surge.sh A11y report: https://patternfly-react-pr-7820-a11y.surge.sh |
Member
Author
|
@jschuler took a stab at what we chatted about around editing CSS import paths (similar to work I was doing in an issue for Codesandbox imports) - it looks to work locally but is breaking the build, I'm also not sure next steps to enhance this to make it opt-in or any additional checks we'd want to run to make sure this doesn't have other unintended consequences. That said, I know you were going to look into this so maybe this will give you a head start 🤞 @mcoker FYI |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #7825
This PR parses CSS files being copied into
react-stylesand replaces relative asset paths with absolute paths.