Skip to content

fix(Page) group section example not keyboard accesible #7712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wise-king-sullyman merged 1 commit into from
Jul 26, 2022
Merged

fix(Page) group section example not keyboard accesible #7712

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 25 additions & 12 deletions packages/react-core/src/components/Page/examples/Page.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ class VerticalPage extends React.Component {
<MastheadContent>{headerToolbar}</MastheadContent>
</Masthead>
);
const Sidebar = <PageSidebar nav="Navigation" isNavOpen={isNavOpen} id="vertical-sidebar"/>;
const Sidebar = <PageSidebar nav="Navigation" isNavOpen={isNavOpen} id="vertical-sidebar" />;

return (
<Page header={Header} sidebar={Sidebar}>
Expand Down Expand Up @@ -262,7 +262,7 @@ class FillPage extends React.Component {
<MastheadContent>{headerToolbar}</MastheadContent>
</Masthead>
);
const Sidebar = <PageSidebar nav="Navigation" isNavOpen={isNavOpen} id="fill-sidebar"/>;
const Sidebar = <PageSidebar nav="Navigation" isNavOpen={isNavOpen} id="fill-sidebar" />;

return (
<Page header={Header} sidebar={Sidebar}>
Expand Down Expand Up @@ -344,7 +344,7 @@ class VerticalPage extends React.Component {
<MastheadContent>{headerToolbar}</MastheadContent>
</Masthead>
);
const Sidebar = <PageSidebar nav="Navigation" isNavOpen={isNavOpen} id="main-padding-sidebar"/>;
const Sidebar = <PageSidebar nav="Navigation" isNavOpen={isNavOpen} id="main-padding-sidebar" />;

return (
<Page header={Header} sidebar={Sidebar}>
Expand Down Expand Up @@ -410,7 +410,7 @@ class UncontrolledNavPage extends React.Component {
<MastheadContent>{headerToolbar}</MastheadContent>
</Masthead>
);
const Sidebar = <PageSidebar nav="Navigation" id="uncontrolled-sidebar"/>;
const Sidebar = <PageSidebar nav="Navigation" id="uncontrolled-sidebar" />;

return (
<Page isManagedSidebar header={Header} sidebar={Sidebar}>
Expand Down Expand Up @@ -497,21 +497,29 @@ class GroupPage extends React.Component {
<MastheadContent>{headerToolbar}</MastheadContent>
</Masthead>
);
const Sidebar = <PageSidebar nav="Navigation" isNavOpen={isNavOpen} id="group-section-sidebar"/>;
const Sidebar = <PageSidebar nav="Navigation" isNavOpen={isNavOpen} id="group-section-sidebar" />;

return (
<Page header={Header} sidebar={Sidebar}>
<PageGroup>
<PageNavigation>
<Nav aria-label="Group section navigation" variant="tertiary">
<NavList>
<NavItem itemId={0} isActive>
<NavItem href="#" itemId={0} isActive>
System panel
</NavItem>
<NavItem itemId={1}>Policy</NavItem>
<NavItem itemId={2}>Authentication</NavItem>
<NavItem itemId={3}>Network services</NavItem>
<NavItem itemId={4}>Server</NavItem>
<NavItem href="#" itemId={1}>
Policy
</NavItem>
<NavItem href="#" itemId={2}>
Authentication
</NavItem>
<NavItem href="#" itemId={3}>
Network services
</NavItem>
<NavItem href="#" itemId={4}>
Server
</NavItem>
</NavList>
</Nav>
</PageNavigation>
Expand Down Expand Up @@ -582,7 +590,7 @@ class VerticalPage extends React.Component {
navToggleId="vertical-pageheader-toggle"
/>
);
const Sidebar = <PageSidebar nav="Navigation" isNavOpen={isNavOpen} id="vertical-pageheader-sidebar"/>;
const Sidebar = <PageSidebar nav="Navigation" isNavOpen={isNavOpen} id="vertical-pageheader-sidebar" />;

return (
<Page header={Header} sidebar={Sidebar}>
Expand Down Expand Up @@ -630,7 +638,12 @@ CenterAlignedPageSection = () => {
const Header = (
<Masthead>
<MastheadToggle>
<PageToggleButton variant="plain" aria-label="Global navigation" onNavToggle={this.onNavToggle} id="centered-nav-toggle">
<PageToggleButton
variant="plain"
aria-label="Global navigation"
onNavToggle={this.onNavToggle}
id="centered-nav-toggle"
>
<BarsIcon />
</PageToggleButton>
</MastheadToggle>
Expand Down