chore(ActionList): update tests to new standards

packages/react-core/src/components/ActionList/__tests__/ActionList.test.tsx

@@ -1,14 +1,49 @@
-import * as React from 'react';
-import { render } from '@testing-library/react';
+import React from 'react';
+import { render, screen } from '@testing-library/react';
 import { ActionList } from '../ActionList';
 
-describe('action list', () => {
-  test('renders successfully', () => {
-    const { asFragment } = render(<ActionList>test</ActionList>);
-    expect(asFragment()).toMatchSnapshot();
-  });
-  test('isIconList flag adds modifier', () => {
-    const { asFragment } = render(<ActionList isIconList>test</ActionList>);
-    expect(asFragment()).toMatchSnapshot();
-  });
+test('Renders without children', () => {
+  render(<ActionList data-testid="action-list" />);
+  expect(screen.getByTestId('action-list')).toBeVisible();
+});
+
+test('Renders children', () => {
+  render(<ActionList>Test</ActionList>);
+
+  expect(screen.getByText('Test')).toBeVisible();
+});
+
+test('Renders with class pf-c-action-list', () => {
+  render(<ActionList>Test</ActionList>);
+
+  expect(screen.getByText('Test')).toHaveClass('pf-c-action-list');
+});
+
+test('Renders with custom class names provided via prop', () => {
+  render(<ActionList className="custom-class">Test</ActionList>);
+
+  expect(screen.getByText('Test')).toHaveClass('custom-class');
+});
+
+test('Does not render with class pf-m-icons by default', () => {
+  render(<ActionList>Test</ActionList>);
+
+  expect(screen.getByText('Test')).not.toHaveClass('pf-m-icons');
+});
+
+test('Renders with class pf-m-icons when isIconList is true', () => {
+  render(<ActionList isIconList={true}>Test</ActionList>);
+
+  expect(screen.getByText('Test')).toHaveClass('pf-m-icons');
+});
+
+test('Renders with inherited element props spread to the component', () => {
+  render(<ActionList aria-label="Test label">Test</ActionList>);
+
+  expect(screen.getByText('Test')).toHaveAccessibleName('Test label');
+})
+
+test('Matches the snapshot', () => {
+  const { asFragment } = render(<ActionList>test</ActionList>);
+  expect(asFragment()).toMatchSnapshot();
 });

packages/react-core/src/components/ActionList/__tests__/ActionListGroup.test.tsx

@@ -1,10 +1,37 @@
-import * as React from 'react';
-import { render } from '@testing-library/react';
+import React from 'react';
+import { render, screen } from '@testing-library/react';
 import { ActionListGroup } from '../ActionListGroup';
 
-describe('action list group', () => {
-  test('renders successfully', () => {
-    const { asFragment } = render(<ActionListGroup>test</ActionListGroup>);
-    expect(asFragment()).toMatchSnapshot();
-  });
+test('Renders without children', () => {
+  render(<ActionListGroup data-testid="action-list-group" />);
+  expect(screen.getByTestId('action-list-group')).toBeVisible();
+});
+
+test('Renders children', () => {
+  render(<ActionListGroup>Test</ActionListGroup>);
+
+  expect(screen.getByText('Test')).toBeVisible();
+});
+
+test('Renders with class pf-c-action-list__group', () => {
+  render(<ActionListGroup>Test</ActionListGroup>);
+
+  expect(screen.getByText('Test')).toHaveClass('pf-c-action-list__group');
+});
+
+test('Renders with custom class names provided via prop', () => {
+  render(<ActionListGroup className="custom-class">Test</ActionListGroup>);
+
+  expect(screen.getByText('Test')).toHaveClass('custom-class');
+});
+
+test('Renders with inherited element props spread to the component', () => {
+  render(<ActionListGroup aria-label="Test label">Test</ActionListGroup>);
+
+  expect(screen.getByText('Test')).toHaveAccessibleName('Test label');
+})
+
+test('Matches the snapshot', () => {
+  const { asFragment } = render(<ActionListGroup>test</ActionListGroup>);
+  expect(asFragment()).toMatchSnapshot();
 });

packages/react-core/src/components/ActionList/__tests__/ActionListItem.test.tsx

@@ -1,10 +1,37 @@
-import * as React from 'react';
-import { render } from '@testing-library/react';
+import React from 'react';
+import { render, screen } from '@testing-library/react';
 import { ActionListItem } from '../ActionListItem';
 
-describe('action list item', () => {
-  test('renders successfully', () => {
-    const { asFragment } = render(<ActionListItem>test</ActionListItem>);
-    expect(asFragment()).toMatchSnapshot();
-  });
+test('Renders without children', () => {
+  render(<ActionListItem data-testid="action-list-item" />);
+  expect(screen.getByTestId('action-list-item')).toBeVisible();
+});
+
+test('Renders children', () => {
+  render(<ActionListItem>Test</ActionListItem>);
+
+  expect(screen.getByText('Test')).toBeVisible();
+});
+
+test('Renders with class pf-c-action-list__item', () => {
+  render(<ActionListItem>Test</ActionListItem>);
+
+  expect(screen.getByText('Test')).toHaveClass('pf-c-action-list__item');
+});
+
+test('Renders with custom class names provided via prop', () => {
+  render(<ActionListItem className="custom-class">Test</ActionListItem>);
+
+  expect(screen.getByText('Test')).toHaveClass('custom-class');
+});
+
+test('Renders with inherited element props spread to the component', () => {
+  render(<ActionListItem aria-label="Test label">Test</ActionListItem>);
+
+  expect(screen.getByText('Test')).toHaveAccessibleName('Test label');
+})
+
+test('Matches the snapshot', () => {
+  const { asFragment } = render(<ActionListItem>test</ActionListItem>);
+  expect(asFragment()).toMatchSnapshot();
 });

packages/react-core/src/components/ActionList/__tests__/__snapshots__/ActionList.test.tsx.snap

@@ -1,16 +1,6 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`action list isIconList flag adds modifier 1`] = `
-<DocumentFragment>
-  <div
-    class="pf-c-action-list pf-m-icons"
-  >
-    test
-  </div>
-</DocumentFragment>
-`;
-
-exports[`action list renders successfully 1`] = `
+exports[`Matches the snapshot 1`] = `
 <DocumentFragment>
   <div
     class="pf-c-action-list"

packages/react-core/src/components/ActionList/__tests__/__snapshots__/ActionListGroup.test.tsx.snap

@@ -1,6 +1,6 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`action list group renders successfully 1`] = `
+exports[`Matches the snapshot 1`] = `
 <DocumentFragment>
   <div
     class="pf-c-action-list__group"

packages/react-core/src/components/ActionList/__tests__/__snapshots__/ActionListItem.test.tsx.snap

@@ -1,6 +1,6 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`action list item renders successfully 1`] = `
+exports[`Matches the snapshot 1`] = `
 <DocumentFragment>
   <div
     class="pf-c-action-list__item"