Skip to content

fix(Select): retain focus on correct checkbox after view more#7505

Merged
tlabaj merged 1 commit intopatternfly:mainfrom
thatblindgeye:select_checked-focus
Jun 9, 2022
Merged

fix(Select): retain focus on correct checkbox after view more#7505
tlabaj merged 1 commit intopatternfly:mainfrom
thatblindgeye:select_checked-focus

Conversation

@thatblindgeye
Copy link
Copy Markdown
Contributor

@thatblindgeye thatblindgeye commented Jun 3, 2022

What: Closes #7132

Select view more example (can also copy+paste the code mentioned in the linked issue)

Additional issues:

@thatblindgeye thatblindgeye requested review from kmcfaul and tlabaj June 3, 2022 15:52
@patternfly-build
Copy link
Copy Markdown
Collaborator

patternfly-build commented Jun 3, 2022

@tlabaj tlabaj added the A11y label Jun 7, 2022
@tlabaj tlabaj requested a review from jessiehuff June 7, 2022 17:05
Copy link
Copy Markdown
Contributor

@jessiehuff jessiehuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I thinkk I might have discovered a separate issue in testing? When you get a second, can you test out this example with VO? It had really odd behavior for me so I'm curious if others are experiencing that too (also saw it when I went and tested on org though).

@thatblindgeye
Copy link
Copy Markdown
Contributor Author

@jessiehuff I am noticing odd behavior as well. For me it's not really being able to navigate between those checkboxes (focus looks to remain on the first item, but the other items get announced but can't be interacted with with VO keys):

View.more.VO.issue.mov

Like you mentioned this does look to be a pre-existing issue, though.

@patternfly-build
Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • eslint-plugin-patternfly-react@4.60.10
  • @patternfly/react-catalog-view-extension@4.72.10
  • @patternfly/react-charts@6.74.10
  • @patternfly/react-code-editor@4.62.10
  • @patternfly/react-console@4.72.10
  • @patternfly/react-core@4.221.10
  • @patternfly/react-docs@5.82.10
  • @patternfly/react-icons@4.72.10
  • @patternfly/react-inline-edit-extension@4.66.10
  • demo-app-ts@4.181.10
  • @patternfly/react-integration@4.183.10
  • @patternfly/react-log-viewer@4.66.10
  • @patternfly/react-styles@4.71.10
  • @patternfly/react-table@4.90.10
  • @patternfly/react-tokens@4.73.10
  • @patternfly/react-topology@4.68.10
  • @patternfly/react-virtualized-extension@4.68.10
  • transformer-cjs-imports@4.59.10

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug - Select - View More + Grouped + Checkbox results in focus returning to a single option

5 participants