fix(react-styles): support esm import and export#7084
Merged
Conversation
The previous version are using `require()`, which is not fully support esm Add esm only output to support some pure esm project like vite or snowpack
Collaborator
|
Preview: https://patternfly-react-pr-7084.surge.sh A11y report: https://patternfly-react-pr-7084-a11y.surge.sh |
mcoker
approved these changes
Apr 8, 2022
Contributor
mcoker
left a comment
There was a problem hiding this comment.
Spot checked a bunch of components, everything looks good to me!
jschuler
approved these changes
Apr 11, 2022
nicolethoen
approved these changes
Apr 11, 2022
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous version are using
require(), which is not fullysupport esm
Add esm only output to support some pure esm project like vite or
snowpack
What: Closes #
Closes #7054
Additional issues: