fix(TextInputGroup): address various issues#6774
Conversation
on auto complete search: undoes default tab behavior prevention undoes input clearing on escape when focused on menu adds input clearing on tab when focused on menu adds placeholder text and custom aria label clarifies reasoning for conditionally rendered search icon on text input group main: sets falsy input values as an empty string exposes value and placeholder props
There was a problem hiding this comment.
Per @nicolethoen, tab behavior should mimic the Search Input example.
Within the menu of Text Input Group, pressing the tab key moves focus to another element in the page. In this case, the menu remained open, which is not expected. It seems the user must press the escape key first?
For Search Input, pressing the tab key returns focus to the input. From there, I can tab to the clear button.
Text Input Group example
Search Input example
|
Tab now closes the menu and focuses on the text input. Additionally, I saw that this demo was missing the search input auto complete demo functionality of closing the menu when |
|
I think if focus is on the input and user hits tab to complete the autocomplete, the menu should close when the focus moves to the next focusable element (the close button) |
|
0b266d4 was added as an alternate solution to patternfly/patternfly#4588. This commit demonstrates how consumers can conditionally render the |
|
LGTM! |
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
On auto complete search:
undoes default tab behavior prevention
undoes input clearing on escape when focused on menu
adds input clearing on tab when focused on menu
adds placeholder text and custom aria label
clarifies reasoning for conditionally rendered search icon
On text input group main:
sets falsy input values as an empty string
exposes value and placeholder props
What: Closes #6697
Additional issues:
Direct link to the auto complete search preview