Skip to content

feat(ToggleGroup): support disabling all items under the parent #6700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlabaj merged 6 commits into from
Jan 11, 2022
Merged

feat(ToggleGroup): support disabling all items under the parent #6700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8013aa1
feat(ToggleGroup): support disabling all items under the parent
boaz0 Dec 14, 2021
abd41ba
fixup! feat(ToggleGroup): support disabling all items under the parent
boaz0 Dec 21, 2021
854cdae
fixup! feat(ToggleGroup): support disabling all items under the parent
boaz0 Dec 21, 2021
b0f80c6
fixup! feat(ToggleGroup): support disabling all items under the parent
boaz0 Dec 22, 2021
845b833
fixup! feat(ToggleGroup): support disabling all items under the parent
boaz0 Dec 28, 2021
fdf14ea
fixup! feat(ToggleGroup): support disabling all items under the parent
boaz0 Jan 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions packages/react-core/src/components/ToggleGroup/ToggleGroup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import * as React from 'react';
import { css } from '@patternfly/react-styles';
import styles from '@patternfly/react-styles/css/components/ToggleGroup/toggle-group';
import { ToggleGroupItem } from './ToggleGroupItem';

export interface ToggleGroupProps extends React.HTMLProps<HTMLDivElement> {
/** Content rendered inside the toggle group */
Expand All @@ -9,6 +10,8 @@ export interface ToggleGroupProps extends React.HTMLProps<HTMLDivElement> {
className?: string;
/** Modifies the toggle group to include compact styling. */
isCompact?: boolean;
/** Disable all toggle group items under this component. */
areAllGroupsDisabled?: boolean;
/** Accessible label for the toggle group */
'aria-label'?: string;
}
Expand All @@ -17,12 +20,15 @@ export const ToggleGroup: React.FunctionComponent<ToggleGroupProps> = ({
className,
children,
isCompact = false,
areAllGroupsDisabled = false,
'aria-label': ariaLabel,
...props
}: ToggleGroupProps) => {
const toggleGroupItemList = [] as any[];
React.Children.forEach(children, child => {
toggleGroupItemList.push(child);
const toggleGroupItemList = React.Children.map(children, child => {
const childCompName = (child as any).type.name;
return childCompName !== ToggleGroupItem.name
? child
: React.cloneElement(child as React.ReactElement, areAllGroupsDisabled ? { isDisabled: true } : {});
});

return (
Expand Down
2 changes: 2 additions & 0 deletions ...s/react-core/src/components/ToggleGroup/__tests__/__snapshots__/ToggleGroup.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,11 @@ exports[`isCompact 1`] = `
role="group"
>
<ToggleGroupItem
key=".0"
text="Test"
/>
<ToggleGroupItem
key=".1"
text="Test"
/>
</div>
Expand Down
29 changes: 21 additions & 8 deletions packages/react-core/src/components/ToggleGroup/examples/ToggleGroup.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ propComponents: ['ToggleGroup', 'ToggleGroupItem']
---
import './toggleGroup.css';

import { ToggleGroup, ToggleGroupItem} from '@patternfly/react-core';
import { ToggleGroup, ToggleGroupItem, Button, Stack, StackItem } from '@patternfly/react-core';
import UndoIcon from '@patternfly/react-icons/dist/esm/icons/undo-icon';
import CopyIcon from '@patternfly/react-icons/dist/esm/icons/copy-icon';
import ShareSquareIcon from '@patternfly/react-icons/dist/esm/icons/share-square-icon';
Expand All @@ -16,15 +16,16 @@ import ShareSquareIcon from '@patternfly/react-icons/dist/esm/icons/share-square
### Default with multiple selectable
```js
import React from 'react';
import { ToggleGroup, ToggleGroupItem } from '@patternfly/react-core';
import { ToggleGroup, ToggleGroupItem, Button, Stack, StackItem } from '@patternfly/react-core';

class DefaultToggleGroupExample extends React.Component {
constructor(props) {
super(props);
this.state = {
isSelected: {
first: false,
second: false
second: false,
disableAll: false
}
};
this.handleItemClick = (isSelected, event) => {
Expand All @@ -36,17 +37,29 @@ class DefaultToggleGroupExample extends React.Component {
};
});
};
this.disableAllClick = () => {
this.setState(prevState => ({ disableAll: !prevState.disableAll }));
};
}

render() {
const { isSelected } = this.state;

return (
<ToggleGroup aria-label="Default with multiple selectable">
<ToggleGroupItem text="Option 1" key={0} buttonId="first" isSelected={isSelected.first} onChange={this.handleItemClick} />
<ToggleGroupItem text="Option 2" key={1} buttonId="second" isSelected={isSelected.second} onChange={this.handleItemClick} />
<ToggleGroupItem text="Option 3" key={2} isDisabled/>
</ToggleGroup>
<Stack hasGutter>
<StackItem>
<Button onClick={this.disableAllClick}>
{this.state.disableAll ? "Enable back" : "Disable all"}
</Button>
</StackItem>
<StackItem>
<ToggleGroup areAllGroupsDisabled={this.state.disableAll} aria-label="Default with multiple selectable">
<ToggleGroupItem text="Option 1" key={0} buttonId="first" isSelected={isSelected.first} onChange={this.handleItemClick} />
<ToggleGroupItem text="Option 2" key={1} buttonId="second" isSelected={isSelected.second} onChange={this.handleItemClick} />
<ToggleGroupItem text="Option 3" key={2} isDisabled/>
</ToggleGroup>
</StackItem>
</Stack>
);
}
}
Expand Down