Skip to content

feat(Toolbar): support customizing text in ToolbarChipGroupContent#6694

Merged
nicolethoen merged 3 commits intopatternfly:mainfrom
boaz0:closes_5836
Dec 22, 2021
Merged

feat(Toolbar): support customizing text in ToolbarChipGroupContent#6694
nicolethoen merged 3 commits intopatternfly:mainfrom
boaz0:closes_5836

Conversation

@boaz0
Copy link
Copy Markdown
Member

@boaz0 boaz0 commented Dec 12, 2021

What: Closes #5836

TODO

  • Add a spec test to verify it works correctly

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
@patternfly-build
Copy link
Copy Markdown
Collaborator

patternfly-build commented Dec 12, 2021

…tent

Fix snapshot in unit tests to include numberOfFiltersText
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
Copy link
Copy Markdown
Contributor

@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@nicolethoen nicolethoen merged commit 24266ad into patternfly:main Dec 22, 2021
@patternfly-build
Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • eslint-plugin-patternfly-react@4.21.0
  • @patternfly/react-catalog-view-extension@4.33.0
  • @patternfly/react-charts@6.35.0
  • @patternfly/react-code-editor@4.23.0
  • @patternfly/react-console@4.33.0
  • @patternfly/react-core@4.182.0
  • @patternfly/react-docs@5.43.0
  • @patternfly/react-icons@4.33.0
  • @patternfly/react-inline-edit-extension@4.27.0
  • demo-app-ts@4.142.0
  • @patternfly/react-integration@4.144.0
  • @patternfly/react-log-viewer@4.27.0
  • @patternfly/react-styles@4.32.0
  • @patternfly/react-table@4.51.0
  • @patternfly/react-tokens@4.34.0
  • @patternfly/react-topology@4.29.0
  • @patternfly/react-virtualized-extension@4.29.0
  • transformer-cjs-imports@4.20.0

Thanks for your contribution! 🎉

@boaz0
Copy link
Copy Markdown
Member Author

boaz0 commented Dec 23, 2021

THANKS 🙇

@boaz0 boaz0 deleted the closes_5836 branch December 23, 2021 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ToolbarChipGroupContent: 'filters applied' string needs to be expose so that it can be I18n

4 participants