fix(popover): forwarded focus to close button with VoiceOver click#6660
Conversation
|
@jschuler I know you've worked with Popper a lot and I believe wrote the code I removed here, WDYT? Want to make sure there's not an edge case I'm unaware of to keep the |
nicolethoen
left a comment
There was a problem hiding this comment.
It seems to me that that in this PR and in production I cannot get VO focus into the popover when it opens. VO focus stays on the toggle, even though it reads the contents of the popover. That is fine except in the example of close-popover-from-content-controlled where I really struggled to figure out how to use VO to hit the controlled close button.
jessiehuff
left a comment
There was a problem hiding this comment.
I agree with Nicole's comment in that there are a few that don't switch focus for me (close popover from content (controlled) and the advanced example). However, I don't think that they currently switched focus through keyboard either looking at org. I'm ok with solving these here or in another issue/PR. I'm open to what you guys think! :)
What: Closes #4210
This PR:
cmd+F5on a Mac to enable VO, thenctrl+option+spaceon button to trigger Popover (see Activate a link or form control)onTriggerEnterfunction passed as a prop to PopperonTriggerClickfunctionality but targeted only at theEnterkey, but that key press was triggering both functions so this seems to be unnecessary.