Skip to content

fix(Tile): fix selecting tile in tile demo#6653

Merged
tlabaj merged 2 commits into
patternfly:mainfrom
nicolethoen:fix_tile_selection
Dec 2, 2021
Merged

fix(Tile): fix selecting tile in tile demo#6653
tlabaj merged 2 commits into
patternfly:mainfrom
nicolethoen:fix_tile_selection

Conversation

@nicolethoen
Copy link
Copy Markdown
Contributor

What: Closes #6637

Also cleans up some unused imports in the Card examples

@patternfly-build
Copy link
Copy Markdown
Collaborator

patternfly-build commented Nov 30, 2021

Copy link
Copy Markdown
Member

@mcarrano mcarrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still cannot get the tiles to reliably stick in the second demo example (multi-select). Sometime they will sometimes they won't. Testing with Firefox.

@nicolethoen
Copy link
Copy Markdown
Contributor Author

@mcarrano good catch! I fixed it

@nicolethoen nicolethoen requested a review from mcarrano December 1, 2021 00:58
Copy link
Copy Markdown
Member

@mcarrano mcarrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@tlabaj tlabaj merged commit e12e44d into patternfly:main Dec 2, 2021
@patternfly-build
Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • eslint-plugin-patternfly-react@4.14.15
  • @patternfly/react-catalog-view-extension@4.26.15
  • @patternfly/react-charts@6.28.15
  • @patternfly/react-code-editor@4.16.15
  • @patternfly/react-console@4.26.15
  • @patternfly/react-core@4.175.15
  • @patternfly/react-docs@5.36.15
  • @patternfly/react-icons@4.26.15
  • @patternfly/react-inline-edit-extension@4.20.15
  • demo-app-ts@4.135.15
  • @patternfly/react-integration@4.137.15
  • @patternfly/react-log-viewer@4.20.15
  • @patternfly/react-styles@4.25.15
  • @patternfly/react-table@4.44.15
  • @patternfly/react-tokens@4.27.15
  • @patternfly/react-topology@4.22.15
  • @patternfly/react-virtualized-extension@4.22.15
  • transformer-cjs-imports@4.13.15

Thanks for your contribution! 🎉

@nicolethoen nicolethoen deleted the fix_tile_selection branch February 8, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent selection in Tile component

6 participants