Skip to content

feat(Alert): Allow all heading levels for title#6628

Merged
tlabaj merged 1 commit intopatternfly:mainfrom
nicolethoen:alert_title_variants
Nov 19, 2021
Merged

feat(Alert): Allow all heading levels for title#6628
tlabaj merged 1 commit intopatternfly:mainfrom
nicolethoen:alert_title_variants

Conversation

@nicolethoen
Copy link
Copy Markdown
Contributor

What: Closes #6444

Added new alerts under 'Variations' example

@patternfly-build
Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Member

@evwilkin evwilkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!! 🔥

Copy link
Copy Markdown
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlabaj tlabaj merged commit ba6082a into patternfly:main Nov 19, 2021
@nicolethoen nicolethoen deleted the alert_title_variants branch February 8, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Alert title is forcing a h4 tag even if a h4 isn't appropriate in context

5 participants