Skip to content

Add ability to provide unique identifier for the Close button in a modal #5856

@jgiardino

Description

@jgiardino

Describe the issue. What is the expected and unexpected behavior?
I originally raised this question in patternfly/patternfly#3913, but feedback was that this is a react issue.

We are currently using data- attributes to uniquely identify elements in the DOM for the purpose of usage analytics. One element we are tracking is the Close button in a modal, but we aren't able to add any additional html attributes to this element. Currently, we're tracking this element using the class name pf-m-plain but this isn't ideal.

What is your product and what release version are you targeting?
No known release. At the moment, we're identifying this action via the pf class name provided, but this method prevents us from adding another .pf-m-plain button to the modal without breaking the metrics we capture.

Metadata

Metadata

Assignees

Type

No type

Projects

Status

Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions