Slider: max and customSteps dont play well together

[mdujava]

In Slider, specifying max lower then 100 and customSteps will not show as intended.

first slider specify both, second only max is specified.

 const freq_steps = [
    { value: 0, label: "A" },
    ...
    { value: 4, label: "E", isLabelHidden: true },
    { value: 5, label: "F" }
  ];
...
// labels are shown, but max is ignored 
  <Slider
      onChange={onChangeFrequency}
      value={frequencyOfTask}
      max={5}
      showTicks
      customSteps={freq_steps}
  />
// max is set correct, but no labels
 <Slider
      onChange={onChangeFrequency}
      value={frequencyOfTask}
      max={5}
      showTicks
  />

https://codesandbox.io/s/hopeful-nash-38mnu?file=/index.js

[mdujava]

Just found out that proper project is https://github.com/patternfly/patternfly-react/, can you please move it there? (https://docs.github.com/en/issues/tracking-your-work-with-issues/managing-issues/transferring-an-issue-to-another-repository)

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[mdujava]

When CustomSteps are applied code uses stepObj.value directly in SliderStep

patternfly-react/packages/react-core/src/components/Slider/Slider.tsx

Lines 344 to 346 in 8c671c4

	<SliderStep
	key={stepObj.value}
	value={stepObj.value}

Compared to automatic steps that calculates relative position (honoring min and max values)

patternfly-react/packages/react-core/src/components/Slider/Slider.tsx

Lines 312 to 323 in 8c671c4

	const stepValue = ((i - min) * 100) / (max - min);
	// If we boundaries but not ticks just generate the needed steps
	// so that we don't pullute them DOM with empty divs
	if (!showTicks && showBoundaries && i !== min && i !== max) {
	continue;
	}
	builtSteps.push(
	<SliderStep
	key={i}
	value={stepValue}