-
Notifications
You must be signed in to change notification settings - Fork 145
feat(Compass): add handbook doc page #4877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
edonehoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some rearranging, syntax, and phrasing things. Lmk if I can clarify anything and feel free to make additional adjustments based on your own expertise/familiarity here!
packages/documentation-site/patternfly-docs/content/AI/Compass/CompassHandbook.md
Outdated
Show resolved
Hide resolved
packages/documentation-site/patternfly-docs/content/AI/Compass/CompassHandbook.md
Outdated
Show resolved
Hide resolved
packages/documentation-site/patternfly-docs/content/AI/Compass/CompassHandbook.md
Outdated
Show resolved
Hide resolved
packages/documentation-site/patternfly-docs/content/AI/Compass/CompassHandbook.md
Outdated
Show resolved
Hide resolved
packages/documentation-site/patternfly-docs/content/AI/Compass/CompassHandbook.md
Outdated
Show resolved
Hide resolved
packages/documentation-site/patternfly-docs/content/AI/Compass/CompassHandbook.md
Outdated
Show resolved
Hide resolved
packages/documentation-site/patternfly-docs/content/AI/Compass/CompassHandbook.md
Outdated
Show resolved
Hide resolved
packages/documentation-site/patternfly-docs/content/AI/Compass/CompassHandbook.md
Outdated
Show resolved
Hide resolved
packages/documentation-site/patternfly-docs/content/AI/Compass/CompassHandbook.md
Outdated
Show resolved
Hide resolved
packages/documentation-site/patternfly-docs/content/AI/Compass/CompassHandbook.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Erin Donehoo <[email protected]>
edonehoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of final little nits, otherwise this doc looks pretty good to me
| subsection: Generative UIs | ||
| --- | ||
|
|
||
| When building generative UI layouts using the Compass components, there are several common patterns to considering during your development. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| When building generative UI layouts using the Compass components, there are several common patterns to considering during your development. | |
| When building generative UI layouts using the Compass components, there are several common patterns to consider during your development process. |
|
|
||
| When building generative UI layouts using the Compass components, there are several common patterns to considering during your development. | ||
|
|
||
| ## Structural patterns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ## Structural patterns |
moving this above the intro line
| source: Development-guide | ||
| subsection: Generative UIs | ||
| --- | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ## Structural patterns |
|
|
||
| Within Compass layouts, elements with a transparent glass background and rounded borders should be wrapped in a `<CompassPanel>` (some Compass components do this automatically). You can adjust various options of the `<CompassPanel>` to adapt its padding and behavior to fit the context of your use case. | ||
|
|
||
| To prevent styling issues, do not nest`<CompassPanel>` components while using the glass effects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| To prevent styling issues, do not nest`<CompassPanel>` components while using the glass effects. | |
| To prevent styling issues, do not nest `<CompassPanel>` components while using the glass effects. |
Closes #4838.