Skip to content

fix: pfe-autocomplete add composed flag to option-selected event #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kylebuch8 merged 2 commits into from
Jul 20, 2020
Merged

fix: pfe-autocomplete add composed flag to option-selected event #988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59d296c
fix: pfe-autocomplete add composed flag to option-selected event
kylebuch8 Jul 20, 2020
c6e82a6
Merge branch 'master' into issue-986-pfe-autocomplete-option-selected…
kylebuch8 Jul 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG-prerelease.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## Prerelease 53 ( TBD )

- []() fix: pfe-autocomplete add composed flag to option-selected event
- [](https://github.com/patternfly/patternfly-elements/commit/) fix: Move pfe-sass to a dev dependency

## Prerelease 52 ( 2020-07-17 )
Expand Down
3 changes: 2 additions & 1 deletion elements/pfe-autocomplete/src/pfe-autocomplete.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,8 @@ class PfeAutocomplete extends PFElement {
} else if (key === KEYCODE.ENTER) {
if (this._activeOption(activeIndex)) {
this.emitEvent(PfeAutocomplete.events.select, {
detail: { optionValue: this._activeOption(activeIndex) }
detail: { optionValue: this._activeOption(activeIndex) },
composed: true
});
}

Expand Down