Skip to content

Conversation

@bennypowers
Copy link
Member

What I did

Add pfe-button as a dependency to pfe-autocomplete

Closes #2102

@changeset-bot
Copy link

changeset-bot bot commented Aug 23, 2022

🦋 Changeset detected

Latest commit: a8fed6e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@patternfly/pfe-button Patch
@patternfly/pfe-icon Patch
@patternfly/eslint-config-elements Patch
@patternfly/pfe-tools Patch
@patternfly/pfe-autocomplete Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bennypowers bennypowers requested a review from zeroedin August 23, 2022 10:39
@bennypowers bennypowers enabled auto-merge (squash) August 23, 2022 10:39
@github-actions github-actions bot added the AT passed Automated testing has passed label Aug 23, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2022

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 4511f68
😎 Deploy Preview https://deploy-preview-2107--patternfly-elements.netlify.app/

_To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added functionality Functionality, typically pertaining to the JavaScript. tools Development and build tools labels Aug 23, 2022
Copy link
Contributor

@heyMP heyMP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤘

@bennypowers bennypowers merged commit a423b01 into main Aug 23, 2022
@bennypowers bennypowers deleted the chore/dependencies/pfe-autocomplete-pfe-button branch August 23, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed functionality Functionality, typically pertaining to the JavaScript. ready to merge tools Development and build tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] pfe-autocomplete depends on pfe-button, but not in package.json

3 participants