Arms & Events PR fixes#1
Conversation
These broke because REDCap has added the 'alerts' parameter in the most recent version. Nothing you did, just an API change
patking02
left a comment
There was a problem hiding this comment.
These look great; thanks for the review.
|
You're welcome! Can you merge this PR into your branch? I don't have permissions to do that. Don't mind the CI failures, they should be fixed when this gets merged into master |
|
Yes. And I think in the ci.yml file, on line 40 if you swap out: With: I think then doctest's will not get run in a fork. It thinks you were the initial github 'actor' since there was some sort of Build 1 when the PR was created here, and then when I tried Build 2 I think it failed (I think the build keeps your username as the actor, but maybe triggering_actor would work...) https://docs.github.com/en/actions/learn-github-actions/contexts#github-context |
With these fixes, the integration tests and doctests will pass. I'm happy to answer any questions you have about the proposed changes. Feel free to change/amend syntax to whatever suites you best