Unify package-install primitive (single micropip code path)#310
Merged
Conversation
…pip (single micropip code path)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were three independent micropip/pip code paths with different semantics:
engineInstall.ts, inlinemicropip.install,pre=only, raw error)_pv_install_micropip,keep_going=True, classifiedPV_INCOMPATIBLE/PV_INSTALL_ERRORerrors)_pv_install_micropip)This extracts the install primitives into one shared source and routes the engine seam through it.
scripts/pathview_install.py:_pv_already_installed,_pv_install_micropip(spec, pre=False, keep_going=True),_pv_install_pip— single source of truth, one error-classification scheme.toolbox/python.ts:TOOLBOX_PYTHON_HELPERSnow composesINTROSPECT_PY + INSTALL_PY + RUNTIME_GLUE(the three install funcs moved out of the inline glue).engineInstall.ts: injectsINSTALL_PYbefore the worker snapshots_clean_globals(so the primitive survives a simulation reset), then installs each package via_pv_install_micropip(...)instead of an inlinemicropip.install.Behaviour is unchanged (same flags per package); the duplication and the divergent error handling are gone.
svelte-check: 0 errors/0 warnings; production build (incl. worker bundle, which resolves the new?rawimport) succeeds.