Use latest tag when navigating to toolbox docs#17
Open
DavidMStraub wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, navigating to toolbox docs stores the version tag in localStorage and uses that version henceforth.
This has the consequence that, even when a package and its docs are updated, a user opening the docs landing page and clicking on the toolbox will see the old docs, without any visual indication that it's outdated.
This simple change uses the latest tag as the default to show whenever a user clicks on the toolbox on the landing page. The localStorage value is still used when explicitly setting the version via dropdown.
In addition to this change, it might make sense to display a banner when viewing old docs (like RTD does).