(DS-2816)[API] feat: handle titelive music product synchronization, c… #20399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4b65019 to
9fb531f
Compare
9fb531f to
8b452ea
Compare
Contributor
tcoudray-pass
left a comment
There was a problem hiding this comment.
Le retour principale c'est qu'il faut simplifier les serializers pour aider à la compréhension et à la maintenabilité :)
| from pcapi.connectors.big_query.queries.base import BaseQuery | ||
| from pcapi.connectors.serialization.titelive_serializers import TiteLiveBookArticle | ||
| from pcapi.core.offers.models import OfferExtraData | ||
| from pcapi.connectors.serialization.titelive_serializers import TiteliveArticle |
Contributor
There was a problem hiding this comment.
Alors la PR est déjà énorme donc c'est pas trop le moment de le faire, mais est-ce qu'à un moment dans les deux semaines qui viennent, tu pourrais faire passer les modèles Titelive sur pydantic V2 :) ? Ça serait grandement apprécié :). Le ticket est ici
Contributor
Author
There was a problem hiding this comment.
yes, je vais faire la migration dans une PR a part 👍
471fc5b to
f17414d
Compare
tcoudray-pass
approved these changes
Dec 2, 2025
Contributor
tcoudray-pass
left a comment
There was a problem hiding this comment.
Mes retours sont des détails
Comment on lines
+27
to
+24
| # We receive gtl_ids without leading zeros, and sometimes without trailing ones. | ||
| # We must add them to have an 8-character code. |
805e58b to
aaf8065
Compare
…reate abstract for titelive synchronization
aaf8065 to
65f182e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…reate abstract for titelive synchronization
🎯 Related Ticket or 🔧 Changes Made
Ticket Notion