update Cargo toml for release v2.4.3#1437
Conversation
WalkthroughUpdated the assets-sha1 value in Cargo.toml under [package.metadata.parseable_ui] to a new checksum in both occurrences. No logic, code, or API changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Cargo.toml (1)
162-165: Non-blocking: consider moving to SHA‑256 for asset integrity.SHA‑1 is collision-prone. When feasible, migrate the pipeline (Cargo.toml key, build.rs verification, release docs) to SHA‑256.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Cargo.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
- GitHub Check: coverage
- GitHub Check: Build Default x86_64-pc-windows-msvc
- GitHub Check: Build Default aarch64-apple-darwin
- GitHub Check: Build Default x86_64-apple-darwin
- GitHub Check: Build Default x86_64-unknown-linux-gnu
- GitHub Check: Quest Smoke and Load Tests for Distributed deployments
- GitHub Check: Build Default aarch64-unknown-linux-gnu
- GitHub Check: Quest Smoke and Load Tests for Standalone deployments
- GitHub Check: Build Kafka aarch64-apple-darwin
- GitHub Check: Build Kafka x86_64-unknown-linux-gnu
🔇 Additional comments (2)
Cargo.toml (2)
162-165: Incorrect — only one [package.metadata.parseable_ui] block foundRepo search shows a single instance in Cargo.toml (lines 162–165) containing assets-sha1; no other occurrences detected.
Likely an incorrect or invalid review comment.
164-164: Verify hosted artifact SHA‑1 matches Cargo.tomlSandbox verification failed: openssl not found. Confirm the SHA‑1 of build.zip at https://parseable-prism-build.s3.us-east-2.amazonaws.com/v2.4.3/build.zip equals abc3842eef4ad66375299bc6f71d5cd5b01c698b (Cargo.toml, line 164). Suggested command (macOS/Linux): curl -fsSL "https://parseable-prism-build.s3.us-east-2.amazonaws.com/v2.4.3/build.zip" -o build.zip && shasum -a 1 build.zip (or sha1sum build.zip).
Summary by CodeRabbit