Skip to content

fix: finish benchmarks migration and remove init.sh from benchmark folders - #1954

Merged
Imod7 merged 1 commit into
masterfrom
domi-benchmarks-fixes
Apr 27, 2026
Merged

fix: finish benchmarks migration and remove init.sh from benchmark folders#1954
Imod7 merged 1 commit into
masterfrom
domi-benchmarks-fixes

Conversation

@Imod7

@Imod7 Imod7 commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

Description

  • Migrated the remaining camelCase benchmark directories to snake_case Lua scripts using the util API
  • Removed all init.sh files from every benchmark folder
  • Refactored scripts/runBenchmarks.ts to call wrk directly.
  • Updated all paths in scripts/benchmarkConfig.ts so every endpoint resolves to an existing directory.
  • Added validation to .github/workflows/benchmark.yml

Reason

The benchmark workflow has been failing on every push to master since #1917 + #1928. The new util.request(handler, path) API expects a function, but the camelCase scripts still passed a table > "attempt to call a table value" > empty benchmarks.txt > 0 entry JSON > github-action-benchmark errors out with No benchmark result was found.

Test plan

  • npx tsc --project scripts/tsconfig.json --noEmit
  • yarn build:scripts
  • Every entry in benchmarkConfig.ts resolves to benchmarks/<dir>/<dir>.lua (30/30)
  • yarn bench --endpoint "/accounts/{accountId}/validate" --time 30s --ws-url wss://rpc.polkadot.io generates non-empty benchmarks.txt containing Avg RequestTime(Latency): 0.50ms
  • generate_benchmark_result.sh on that output produces a 1-entry valid JSON

@Imod7
Imod7 requested review from a team as code owners April 27, 2026 16:38
@Imod7
Imod7 merged commit 827da6a into master Apr 27, 2026
12 checks passed
@Imod7
Imod7 deleted the domi-benchmarks-fixes branch April 27, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants