fix: finish benchmarks migration and remove init.sh from benchmark folders - #1954
Merged
Conversation
TarikGul
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
utilAPIinit.shfiles from every benchmark folderscripts/runBenchmarks.tsto callwrkdirectly.scripts/benchmarkConfig.tsso every endpoint resolves to an existing directory..github/workflows/benchmark.ymlReason
The benchmark workflow has been failing on every push to master since #1917 + #1928. The new
util.request(handler, path)API expects a function, but the camelCase scripts still passed a table > "attempt to call a table value" > emptybenchmarks.txt> 0 entry JSON >github-action-benchmarkerrors out withNo benchmark result was found.Test plan
npx tsc --project scripts/tsconfig.json --noEmityarn build:scriptsbenchmarkConfig.tsresolves tobenchmarks/<dir>/<dir>.lua(30/30)yarn bench --endpoint "/accounts/{accountId}/validate" --time 30s --ws-url wss://rpc.polkadot.iogenerates non-emptybenchmarks.txtcontainingAvg RequestTime(Latency): 0.50msgenerate_benchmark_result.shon that output produces a 1-entry valid JSON