Skip to content

fix: set lua path in runBenchmarks #1933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Imod7 merged 1 commit into from
Mar 30, 2026
Merged

fix: set lua path in runBenchmarks #1933

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion scripts/runBenchmarks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ const writeResultsToFile = (results: IBenchResult[]) => {
};

/**
* Launch a single benchmark. It returns the stdout from `<root>/benchmarks/util/util.lua`.
* Launch a single benchmark. It returns the stdout from wrk's Lua done() callback.
*
* @param endpoint Endpoint that reflects one of the keys from `benchmarkConfig`.
* @param wsUrl `wsUrl` to benchmark off of.
Expand Down Expand Up @@ -137,6 +137,10 @@ const main = async (args: IBenchParseArgs) => {
if (log_level) setLogLevel(log_level);
setBenchTime(args.time);

// Set LUA_PATH so wrk Lua scripts can require("util") and require("report")
// from any benchmark subdirectory without needing per-script package.path hacks.
process.env.LUA_PATH = `${process.cwd()}/benchmarks/?.lua;;`;

console.log('Building Sidecar...');
const sidecarBuild = await launchProcess('yarn', procs, defaultSasBuildOpts);

Expand Down
Loading